Ask users to provide a new google oauth credential if current one is invalid #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
changed the title
FrankApiyo
force-pushed
the
delete-invalid-credentials-and-ask-for-reauthentication
branch
2 times, most recently
from
7a3103c
to
fb6f249
Compare
DavisRayM
suggested changes
Oct 17, 2022
DavisRayM
reviewed
Oct 17, 2022
FrankApiyo
force-pushed
the
delete-invalid-credentials-and-ask-for-reauthentication
branch
from
54e84a9
to
d24ee08
Compare
|
@FrankApiyo Could we add a test case for refreshing credentials and assert whether they are valid or not expired when the refresh is successful? |
This would be a bit tricky because we would need to provide an example of a valid google credential that would have to be attached to a google account, introducing a potentially flaky test since it would have to make an API request to google. I also think such a test would be testing google OAuth API and not our code, don't you think so? |
FrankApiyo
force-pushed
the
delete-invalid-credentials-and-ask-for-reauthentication
branch
2 times, most recently
from
8469938
to
d2c37d6
Compare
KipSigei
previously approved these changes
Oct 21, 2022
FrankApiyo
force-pushed
the
delete-invalid-credentials-and-ask-for-reauthentication
branch
from
d2c37d6
to
9ee1ee9
Compare
KipSigei
approved these changes
Oct 24, 2022
FrankApiyo
deleted the
delete-invalid-credentials-and-ask-for-reauthentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have: